Merged
Conversation
This was referenced Dec 7, 2025
naisila
force-pushed
the
naisila/upgrade_uncrustify
branch
from
87a8dfa to
c5bc1a6
Compare
naisila
force-pushed
the
naisila/upgrade_uncrustify
branch
from
c5bc1a6 to
e129d02
Compare
eaydingol
approved these changes
Dec 11, 2025
eaydingol
left a comment
eaydingol
left a comment
There was a problem hiding this comment.
LGTM,
uncurstify related changes w.r.to the linked documentation look good.
Test failures do not seem to be related to this PR (not related / failing in other PRs too).
@naisila, as you already looked into those, can you also add a comment here.
Contributor
Author
|
Thanks @eaydingol |
naisila
added a commit
to citusdata/the-process
that referenced
this pull request
Dec 11, 2025
Upgrades uncrustify to 0.82.0 (see below), downgrades pg versions since we will bump versions in Citus _after_ we fix style images. Getting the following error with uncrustify 0.68.1: ``` + cmake .. CMake Error at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.5 has been removed from CMake. ``` Fix: 0.78.0 is the oldest version with cmake_minimum_required(VERSION 3.5). However, I suggest going with the newest version of uncrustify, 0.82.0, since were gonna update all things anyway, might as well use the newest version. Sister PRs citusdata/citus#8373 citusdata/tools#382
Contributor
Author
|
https://github.com/citusdata/tools/actions/runs/20131145276 |
naisila
added a commit
to citusdata/citus
that referenced
this pull request
Dec 11, 2025
This upgrade has changed some indentation levels, moved some parameter names to the next line etc. I also did some manual style changes to obey the 88-90 character per line rule and avoid commas or semicolons in a new line. Sister PRs citusdata/tools#382 citusdata/the-process#179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference for the changes made in this PR https://github.com/uncrustify/uncrustify/blob/uncrustify-0.82.0/documentation/htdocs/config.txt
Sister PRs citusdata/citus#8373 citusdata/the-process#179